Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Redis::setItems - the last item is overwritten #6324

Closed
wumch opened this issue May 25, 2014 · 3 comments
Closed

Redis::setItems - the last item is overwritten #6324

wumch opened this issue May 25, 2014 · 3 comments
Assignees
@Ocramius
Labels
bug Cache
Milestone
2.3.4

Comments

@wumch
Copy link

wumch commented May 25, 2014

In this case:

$keyValuePairs = array('lastButOne' => 'valueOfLastButOne', 'last' => 'valueOfLast');
Zend\Cache\Storage\Adapter\Redis::setItems($keyValuePairs);

what will be written is actually:

$keyValuePairs = array('lastButOne' => 'valueOfLastButOne', 'last' => 'valueOfLastButOne' /* the last value will be overwritten to the last but one's. */ );

This is caused by line 256 and 267 of Zend/Cache/Storage/Adapter/Redis.php,
reference "&$value" defined at line 256 is overwritten by variable "$value" defined at line 267.
@wumch wumch changed the title Redis setItems - the last item will be overwritten Redis::setItems - the last item is overwritten May 25, 2014
@Ocramius
Copy link
Member

Absolute URI: https://github.com/zendframework/zf2/blob/b9205b14fc7cf4ce175ae180e63e2c7007ed56d8/library/Zend/Cache/Storage/Adapter/Redis.php#L256-L267

@segrax segrax mentioned this issue Jun 4, 2014
Closed
@marc-mabe marc-mabe mentioned this issue Aug 14, 2014
Closed
adamlundrigan pushed a commit to adamlundrigan/zf2 that referenced this issue Nov 15, 2014
@marc-mabe @adamlundrigan
fixed zendframework#6324: Redis::setItems: the last item is overwritten
ea96e3e
@adamlundrigan
Copy link
Contributor

This is fixed in open PR #6575

Ocramius added a commit that referenced this issue Nov 22, 2014
@Ocramius
Merge branch 'hotfix/#6575-redis-setitems-last-item-overwritten-fixes-#…
f233ab7 
…6324'

Close #6575
Close #6324
Ocramius added a commit that referenced this issue Nov 22, 2014
@Ocramius
Merge branch 'hotfix/#6575-redis-setitems-last-item-overwritten-fixes-#…
bbf020f 
…6324' into develop

Close #6575
Close #6324
Forward port #6575
Forward port #6324
@Ocramius Ocramius self-assigned this Nov 22, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Nov 22, 2014
@Ocramius
Copy link
Member

Handled in #6575

gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@marc-mabe @Ocramius
fixed zendframework/zendframework#6324: Redis::setItems: the last ite…
5e75ab8 
…m is overwritten
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6575-redis-setitems-…
cff3f33 
…last-item-overwritten-fixes-zendframework/zf2#6324'

Close zendframework/zendframework#6575
Close zendframework/zendframework#6324
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6575-redis-setitems-…
f173d66 
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop

Close zendframework/zendframework#6575
Close zendframework/zendframework#6324
Forward port zendframework/zendframework#6575
Forward port zendframework/zendframework#6324
boesing pushed a commit to laminas/laminas-cache-storage-adapter-test that referenced this issue May 24, 2020
@marc-mabe @Ocramius
fixed zendframework/zendframework#6324: Redis::setItems: the last ite…
0d3c969 
…m is overwritten
boesing pushed a commit to laminas/laminas-cache-storage-adapter-test that referenced this issue May 24, 2020
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6575-redis-setitems-…
e59ada6 
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop

Close zendframework/zendframework#6575
Close zendframework/zendframework#6324
Forward port zendframework/zendframework#6575
Forward port zendframework/zendframework#6324
boesing pushed a commit to laminas/laminas-cache-storage-adapter-apc that referenced this issue May 24, 2020
@marc-mabe @Ocramius
fixed zendframework/zendframework#6324: Redis::setItems: the last ite…
906d8f0 
…m is overwritten
boesing pushed a commit to laminas/laminas-cache-storage-adapter-apc that referenced this issue May 24, 2020
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6575-redis-setitems-…
0dda0ef 
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop

Close zendframework/zendframework#6575
Close zendframework/zendframework#6324
Forward port zendframework/zendframework#6575
Forward port zendframework/zendframework#6324
boesing pushed a commit to laminas/laminas-cache-storage-adapter-redis that referenced this issue Jul 5, 2020
@marc-mabe @Ocramius
fixed zendframework/zendframework#6324: Redis::setItems: the last ite…
a2c28f9 
…m is overwritten
boesing pushed a commit to laminas/laminas-cache-storage-adapter-redis that referenced this issue Jul 5, 2020
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6575-redis-setitems-…
9ae191a 
…last-item-overwritten-fixes-zendframework/zf2#6324' into develop

Close zendframework/zendframework#6575
Close zendframework/zendframework#6324
Forward port zendframework/zendframework#6575
Forward port zendframework/zendframework#6324
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug Cache
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

fixed #6324: Redis::setItems: the last item is overwritten
3 participants
@Ocramius @adamlundrigan @wumch