Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Config\Reader\Xml bug with close file after open #6730

Closed
NikolayFilatov opened this issue Oct 3, 2014 · 2 comments
Closed

Zend\Config\Reader\Xml bug with close file after open #6730

NikolayFilatov opened this issue Oct 3, 2014 · 2 comments
Assignees
@Ocramius
Labels
bug Config
Milestone
2.3.4

Comments

@NikolayFilatov
Copy link

Hi, i thing xml reader has a bag in "fromFile" method at line 78. Maybe after need add line "$this->reader->close()" ? Thanks for help =))
samsonasik added a commit to samsonasik/zf2 that referenced this issue Oct 14, 2014
@samsonasik
Fixes zendframework#6730 : close xml reader on fromFile after it open
fecec34
@samsonasik samsonasik mentioned this issue Oct 14, 2014
Closed
@samsonasik
Copy link
Contributor

@NikolayFilatov I created PR #6761 for it

samsonasik added a commit to samsonasik/zf2 that referenced this issue Dec 22, 2014
@samsonasik
Fixes zendframework#6730 : close xml reader on fromFile after it open
9058f60
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - config reader should disallow opening non existing files
83d0489
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - using reflection to access the internal config reader
8abd686
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - using reflection to access the internal config reader
2df6f59
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - removing newly introduced getter (not needed)
e1fd0b8
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - simplifying test case for non-existing paths
8351e88
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - removing unused variable
0bfeb8f
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
#6730 #6761 - clarifying on weird warning assertions
5bc511c
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
Merge branch 'hotfix/#6761-#6730-xmlreader-fromfile-and-fromstring-sh…
da67b48 
…ould-be-closed' into develop

Close #6761
Close #6730
Forward port #6761
Forward port #6730
Ocramius added a commit that referenced this issue Dec 31, 2014
@Ocramius
Merge branch 'hotfix/#6761-#6730-xmlreader-fromfile-and-fromstring-sh…
bfc0eb6 
…ould-be-closed'

Close #6761
Close #6730
@Ocramius
Copy link
Member

Handled in #6761

@Ocramius Ocramius self-assigned this Dec 31, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Dec 31, 2014
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@samsonasik @Ocramius
Fixes zendframework/zendframework#6730 : close xml reader on fromFile…
5146c02 
… after it open
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - c…
1cf0b93 
…onfig reader should disallow opening non existing files
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - u…
c27b2a0 
…sing reflection to access the internal config reader
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - u…
9d716f3 
…sing reflection to access the internal config reader
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - r…
2f5b7f6 
…emoving newly introduced getter (not needed)
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - s…
a3ee4bb 
…implifying test case for non-existing paths
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - r…
def4708 
…emoving unused variable
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
zendframework/zendframework#6730 zendframework/zendframework#6761 - c…
138488a 
…larifying on weird warning assertions
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6761-zendframework/z…
e0a7446 
…endframework#6730-xmlreader-fromfile-and-fromstring-should-be-closed'

Close zendframework/zendframework#6761
Close zendframework/zendframework#6730
gianarb pushed a commit to zendframework/zend-config that referenced this issue May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6761-zendframework/z…
51f8ace 
…endframework#6730-xmlreader-fromfile-and-fromstring-should-be-closed' into develop

Close zendframework/zendframework#6761
Close zendframework/zendframework#6730
Forward port zendframework/zendframework#6761
Forward port zendframework/zendframework#6730
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug Config
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Fixes #6730 : close() xml reader on fromFile() and fromString() samsonasik/zf2
3 participants
@Ocramius @samsonasik @NikolayFilatov