This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Db\Sql setTable method ommit array #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add array type for setting table
ghost
assigned 
| @@ -48,7 +48,7 @@ public function hasTable() | |||
|
|
|||
| public function setTable($table) | |||
| { | |||
| if (is_string($table) || $table instanceof TableIdentifier) { | |||
| if (is_string($table) || is_array($table) || $table instanceof TableIdentifier) { | |||
| $this->table = $table; | |||
| } else { | |||
| throw new Exception\InvalidArgumentException('Table must be a string or instance of TableIdentifier.'); | |||
There was a problem hiding this comment.
so the exception should be 'Table must be a string, array, or instance of TableIdentifier.'
There was a problem hiding this comment.
Exact ! I have forget this.
Add information to the Exception
Modify the exception on SqlTest
Adding information to the protected $table relative to its type
Adding information about $table property
ralphschindler
pushed a commit
that referenced
this pull request
May 9, 2013
ralphschindler
pushed a commit
that referenced
this pull request
May 9, 2013
ralphschindler
pushed a commit
that referenced
this pull request
May 9, 2013
Merge branch 'YannickDa-SqlSetTable' into develop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add array type for setting table