This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add isActive method Navigation Page Uri. #4348
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of using the request object, the router was already available thats why I used it. How would you match the active route with only the uri string to go by, that was the dilemma i had trying to make the active route active css wise. The router its so much more definitive than a uri string but the above works for simple use cases. |
|
I agree with @DASPRiD and @froschdesign here. If you can make the changes in the by Tuesday at noon GMT, I'll consider them for 2.2.0; otherwise, we'll have to delay them to 2.3.0. |
Awesome! I'm not an expert with phpunit but I'll try my best. :) |
Please add one clean commit! There are to many forward and backward steps in your commits. |
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
Add isActive method Navigation Page Uri.
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
- Only inject request if it is an HTTP request - Allow injecting a null value for request in URI page type
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
- indentation - trailing whitespace
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
ghost
assigned weierophinney
May 22, 2013
Merged to develop for release in 2.3.0. |
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Add isActive method Navigation Page Uri.
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
- Only inject request if it is an HTTP request - Allow injecting a null value for request in URI page type
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
- indentation - trailing whitespace
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds active links to Zend Navigation pages generated using the uri container key. This is an attempt to fix #4346