-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add coveralls support and fix a few testing bugs related to coverage #4397
Conversation
Mhh, something's still wrong with composer it seems. |
Please try to set |
Oh indeed, I totally forgot that we have "library" as source folder, thanks. |
Oh, just saw that you are the developer of php-coveralls, nice work on that! |
Changes Unknown when pulling 43e9a61 on DASPRiD:feature/coveralls-support into * on zendframework:master*. |
@@ -8,6 +8,27 @@ | |||
], | |||
"homepage": "http://framework.zend.com/", | |||
"license": "BSD-3-Clause", | |||
"repositories": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcov comes without composer support. perhabs someone can make a PR there first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure a requirement before this goes in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, at least we are already on a stable tag here ;)
Related issue, should be fixed soon (as in, today or tomorrow): |
Add coveralls support and fix a few testing bugs related to coverage
- EOF ending - trailing whitespace
Merged to develop for 2.3.0 release. |
…ure/coveralls-support Add coveralls support and fix a few testing bugs related to coverage
…ure/coveralls-support Add coveralls support and fix a few testing bugs related to coverage
…ure/coveralls-support Add coveralls support and fix a few testing bugs related to coverage
- EOF ending - trailing whitespace
This PR adds coveralls support (https://coveralls.io/) to ZF2. This tool integrates nicely with both GitHub and Travis, and allows us to keep track of our code coverage.
In the same run I fixed a few broken
@covers
annotations and a bug which prevented complete testing on Ubuntu 12.04 (see comments in the diff).Coveralls status can be found at https://coveralls.io/r/zendframework/zf2