This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
add flag for fallback value #4401
Merged
weierophinney
merged 5 commits into
zendframework:develop
from
tolean:feature/empty_fallback_value
May 22, 2013
Merged
add flag for fallback value #4401
weierophinney
merged 5 commits into
zendframework:develop
from
tolean:feature/empty_fallback_value
May 22, 2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -272,4 +272,30 @@ public function testDoNotInjectNotEmptyValidatorIfAnywhereInChain() | |||
$this->assertEquals(2, count($validators)); | |||
$this->assertEquals($notEmptyMock, $validators[1]['instance']); | |||
} | |||
|
|||
public static function dataFallbackValue() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be static
besides my small note, good to merge |
Please check the unit tests -- this introduces regressions. |
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
add flag for fallback value
weierophinney
added a commit
that referenced
this pull request
May 22, 2013
ghost
assigned weierophinney
May 22, 2013
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…re/empty_fallback_value add flag for fallback value
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can set empty string or null in fallback value