Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

!IE support for conditional comments powered viewhelper #4679

Closed
wants to merge 3 commits into from
Closed

!IE support for conditional comments powered viewhelper #4679

wants to merge 3 commits into from

Conversation

henryruhs
Copy link

Support for conditional comments with !IE by adding the inner wrap with comment end and start.

<!--[if IE 6]>
<p>You are using Internet Explorer 6.</p>
<![endif]-->
<!--[if !IE]><!-->
<p>You are not using Internet Explorer.</p>
<!--<![endif]-->

@localheinz
Copy link
Member

Tests are missing, I guess.

@henryruhs
Copy link
Author

i guess there is no need for additional tests^^

@mwillbanks
Copy link
Contributor

@redaxmedia actually there is a need for additional tests to ensure the behavior that you had added actually works. The behavior was not there before and in the event it would be removed in the future no tests would break so it would seem like all is OK with the world.

@localheinz
Copy link
Member

@redaxmedia actually there is a need for additional tests to ensure the behavior that you had added actually works. The behavior was not there before and in the event it would be removed in the future no tests would break so it would seem like all is OK with the world.

If this was understood as a generalization, wouldn't that mean that no tests are required ever?

@henryruhs
Copy link
Author

Unit tests added, they are working well under zf1
(related pull request: zendframework/zf1#128)

I could not test it under zf2, because my VM Image does not have latest PHPUnit and I could not get it to update because of limited permission. Sorry for that.

@ghost ghost assigned weierophinney Jun 28, 2013
weierophinney added a commit that referenced this pull request Jun 28, 2013
!IE support for conditional comments powered viewhelper
weierophinney added a commit that referenced this pull request Jun 28, 2013
- trailing whitespace
weierophinney added a commit that referenced this pull request Jun 28, 2013
@weierophinney
Copy link
Member

Fixed CS issues and merged to develop for release with 2.3.0.

weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
…aster

!IE support for conditional comments powered viewhelper
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants