This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
LoggerAwareInterface and its Trait #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added accessor for logger instance. Doc blocks.
Added accessor
The accessor being defined in the interface would break current implementations of the interface. Nevertheless, for consistency, I would like to see this somewhen active as it is implemented with the LoggerAwareTrait.
trailing spaces removed
removed trailing spaces
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2013
LoggerAwareInterface and its Trait
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2013
ghost
deleted the
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
LoggerAwareInterface and its Trait
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am missing the accessor for the logger instance when using the trait.