This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Zend log filter sample #4813
Merged
weierophinney
merged 3 commits into
zendframework:develop
from
qapa:zend-log-filter-sample
Jul 19, 2013
Merged
Zend log filter sample #4813
weierophinney
merged 3 commits into
zendframework:develop
from
qapa:zend-log-filter-sample
Jul 19, 2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
I don't understand why Travis failed (only for PHP 5.3.3), it seems to be related to the test logic itself. |
@corentin-larose The failure doesn't seem to be based on your test - the Log tests are passing. I'll review today. |
* | ||
* @var float | ||
*/ | ||
protected $_sampleRate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer underscore-prefix non-public members; I can change this during merge.
ghost
assigned weierophinney
Jul 19, 2013
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
- no longer underscore-prefixing non-public properties
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…g-filter-sample Zend log filter sample
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
- no longer underscore-prefixing non-public properties
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter is intended to sample events by a given factor for events intensive scripts.
Never forget this is a random based sampling, thus, you never exactly know which event will be logged.
Usage: