This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Make HTTP auth adapter's challengeClient() method public #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corentin-larose
commented
Jul 12, 2013
corentin-larose
commented
- changed _challengeClient() as deprecated proxy
- pushed in the proper branch
added 3 commits
July 11, 2013 13:45
… since one could need to call it this way: <code>$auth->getAdapter()->challengeClient();</code> for instance when the authenticated user tries to access a resource for which he is not granted by ACLs.
2 similar comments
|
Please add in a unit test that checks for the deprecated method to throw an error and properly returns back the correct response. |
|
My bad, should have done that. |
added 3 commits
July 16, 2013 08:00
ZendTest\Authentication\Adapter\HttpTest::testProtectedMethodChallengeClientTriggersErrorDeprecated PHP_CodeCoverage_Exception: Trying to @cover not existing method "Adapter\Http::_challengeClient".
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
Make HTTP auth adapter's challengeClient() method public
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
- Ensure the message indicate the method being invoked, and the fully-qualified method name of the replacement.
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
weierophinney
added a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
…mework/zendframework#4563 Make HTTP auth adapter's challengeClient() method public
weierophinney
added a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
- Ensure the message indicate the method being invoked, and the fully-qualified method name of the replacement.
weierophinney
added a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.