This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Simplification of the HTML class name in Tag\Cloud\Decorator\HtmlCloud #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lCloud Changed from "Zend\Tag\Cloud" to "zend-tag-cloud"
|
@froschdesign There is no a hard limit with 80 characters width. |
|
@Maks3w
and
Did I miss something? |
|
That are not hard limits, just recomendations. There is no plan for change all the lines of the framework to match that recomendations. Actually in zf2 only the recommendation apply to new/modified lines |
|
I do not want to change all the lines of the framework! Only the files which I have modified. |
| ); | ||
| $this->assertTrue( | ||
| $cloud->getCloudDecorator() instanceof TestAsset\CloudDummy | ||
| ); |
There was a problem hiding this comment.
Use assertInstanceOf() here.
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
Simplification of the HTML class name in Tag\Cloud\Decorator\HtmlCloud
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
- If we're going to make readability changes, let's make them consistent
with the rest of the framework:
- array arguments should all have commas following each entry
- array arguments as sole argument of a method can open on same line
as call; indentation then adjusts one level less
- Use `assertInstanceOf` throughout, instead of `assertTrue($a instanceof $b)`
- While the `setExpectedException()` lines get a little long, they're
not unreadable; breaking them into multiple lines makes intent less
clear.
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-tag
that referenced
this pull request
May 15, 2015
…/hotfix/zend-tag-cloud Simplification of the HTML class name in Tag\Cloud\Decorator\HtmlCloud
weierophinney
added a commit
to zendframework/zend-tag
that referenced
this pull request
May 15, 2015
- If we're going to make readability changes, let's make them consistent
with the rest of the framework:
- array arguments should all have commas following each entry
- array arguments as sole argument of a method can open on same line
as call; indentation then adjusts one level less
- Use `assertInstanceOf` throughout, instead of `assertTrue($a instanceof $b)`
- While the `setExpectedException()` lines get a little long, they're
not unreadable; breaking them into multiple lines makes intent less
clear.
weierophinney
added a commit
to zendframework/zend-tag
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from "
Zend\Tag\Cloud" to "zend-tag-cloud"