This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
is bin/pluginmap_generator.php broken ? #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samsonasik is this actually something that is still used? |
|
@Ocramius I don't know, should is it removed ? |
|
@samsonasik looks like an old version of the classmap generator... |
|
I propose it to be removed at #5057 |
- Fixed some assumptions that changed along the way with regards to what the PhpClassFile class composes and returns. Added the ability to aggregate namespaces as well as classes in PhpClassFile, and a getter for the namespaces, in order to make the pluginmap_generator work. - Modified the pluginmap_generator to use the new methods.
|
@samsonasik Please test this PR -- my tests show it working with these changes. If so, I'll get somebody to review and merge. |
|
@weierophinney I've test and got : should '\' should be '' ( single backslash ) ? |
|
@samsonasik no, the double backslashes are actually ok |
|
ok 👍 |
| @@ -122,11 +122,20 @@ | |||
| // Iterate over each element in the path, and create a map of pluginname => classname | |||
| $map = new \stdClass; | |||
| foreach ($l as $file) { | |||
| $namespaces = $file->getNamespaces(); | |||
| $namespace = empty($file->namespace) ? '' : $file->namespace . '\\'; | |||
There was a problem hiding this comment.
This variable is not used since is overwritten in the second foreach
ghost
assigned
Maks3w
added a commit
that referenced
this pull request
Oct 20, 2013
Maks3w
added a commit
that referenced
this pull request
Oct 20, 2013
Maks3w
added a commit
that referenced
this pull request
Oct 20, 2013
weierophinney
added a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
- Fixed some assumptions that changed along the way with regards to what the PhpClassFile class composes and returns. Added the ability to aggregate namespaces as well as classes in PhpClassFile, and a getter for the namespaces, in order to make the pluginmap_generator work. - Modified the pluginmap_generator to use the new methods.
gianarb
pushed a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-file
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried run bin/pluginmap_generator.php via console and produce error :