This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[ServiceManager] Implemented circular alias reference detection #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceManagers that allow overwriting the service definition may contain circular references which will cause an infinite loop. Extracted alias resolving code to a protected method that will detect circular references.
|
@tux-rampage wouldn't it be easier to handle this kind of logic in |
| @@ -810,4 +810,25 @@ public function testUsesMultipleDelegates() | |||
| $this->assertInstanceOf('stdClass', array_shift($fooDelegator->instances)); | |||
| $this->assertSame($fooDelegator, array_shift($barDelegator->instances)); | |||
| } | |||
|
|
|||
| /** | |||
| * @covers Zend\ServiceMnager\ServiceManager::resolveAlias | |||
There was a problem hiding this comment.
typo ServiceMnager instead of ServiceManager, miss 'a' after 'M'
|
@Ocramius Might need to think about it. It's not as easy as putting it in the resolve logics. We should also keep in mind that $aliases is a protected and not a private member. So derived classes may manipulate it aside from setAlias(). |
|
@Ocramius It might be doable in the |
|
@Ocramius I added a cycle check to setAlias() as well and modified the unit test accordingly |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
[ServiceManager] Implemented circular alias reference detection
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
- one argument per line (sprintf call)
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…sm-cyclic-alias-ref [ServiceManager] Implemented circular alias reference detection
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
- one argument per line (sprintf call)
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceManagers that allow overwriting the service definition may
contain circular references which will cause an infinite loop.
I extracted the alias resolving code to a protected method that will detect
circular references and throw an exception if one is encountered.