This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Method scanner fixed #5125
Merged
Method scanner fixed #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test for this case added anyway
| $method = $class->getMethod('four'); | ||
| $paramTwo = $method->getParameter(1); | ||
| $optionalValue = $paramTwo->getDefaultValue(); | ||
| $this->assertEquals('array(array(array(\'default\')))', trim($optionalValue)); |
There was a problem hiding this comment.
Shoudn't be needed trim here. If there is some unnecesary space in the value should be removed in the implementation.
There was a problem hiding this comment.
ok, I'll spend more time to locate where is.
|
@olekhy Did you find time for locate that? |
ghost
assigned 
|
not yet I am very busy now. I'm sorry On Mon, Oct 21, 2013 at 10:58 AM, Maks notifications@github.com wrote:
|
Kill0p
pushed a commit
to Kill0p/zf2
that referenced
this pull request
Nov 18, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method scanner can not utilized because scanning of latest param with array as default value returned not expected value instead a funny string...