This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix not allowed encoding of content-transfer-encoding and content-type headers in single part encoded mails #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for single-part mime mails.
added 2 commits
September 19, 2013 22:35
added 2 commits
September 19, 2013 22:49
| * | ||
| * @param string $transferEncoding | ||
| * @throws Exception\InvalidArgumentException | ||
| * @return ContentTransferEncoding |
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com) | ||
| * @license http://framework.zend.com/license/new-bsd New BSD License | ||
| * @package Zend_Mail |
There was a problem hiding this comment.
@samsonasik You are missing capabalities :) Where are you comment about @package ...
@2DivisionsByZero Please remove package, subpackage and category
as requested by @samsonasik
|
@Maks3w @samsonasik Is the request OK now? |
|
👍 |
|
|
||
| public function setEncoding($encoding) | ||
| { | ||
| // This header must be always in US-ASCII |
There was a problem hiding this comment.
I'd rather throw an exception here, instead of silently ignoring the setting (if possible).
There was a problem hiding this comment.
Not changed because it should not be changed regardless what encoding the rest of the message is changed to.
Similar to ContentType.
- do simple in_array comparison for transfer encoding - remove to many spaces befor equal sign - use camelCase var names
ghost
assigned
|
|
||
| namespace Zend\Mail\Header; | ||
|
|
||
| use Zend\Mail\Headers; |
|
Finally header classes needs to be adapted for the future #5291 since introduce the same bug about headerline split |
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…nges. Adapt code to design changes added by zendframework/zendframework#5291 and zendframework/zendframework#5303
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for single-part mime mails.
See #5128
Requires #5303
Needs to be adapted if #5291 is merged.