This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix calling View\Helper\BasePath from CLI results in fatal error. #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump Merge or discuss it please. |
There is no reason for comments like this; there is nothing that makes any individual PR more important than the others in the queue. |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Fix calling View\Helper\BasePath from CLI results in fatal error.
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
- we do not typically declare member variables inside test cases - restored space for operator alignment
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
in view script when compiling views in CLI (with
Console\Request) results in a fatal error:I've fixed it so it'll construct the helper correctly, but using basePath() it in CLI will still throw a (catchable) exception. At least it's something that can be handled in userland, as opposed to PHP fatal error, though I welcome any suggestions on what else could we do with missing basePaths in such case.
Personally, I'm using view scripts to generate email bodies (in cli worker for example).