This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Bug fix for Zend\Form\Element\Collection::extract() #5220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two things:
|
When a Traversable is encountered it is converted to an array. By default this is done recursively, so that the Traversable becomes an array representation. The result of that is saved in $this->object. In the Colletion::extract method when iterating over $this->object there are two branches: 1. If there is a hydrator, its extract method is called which expects $value as an object. 2. If $value is an instance of the targetElement, eventualy setObject($value) is called on a fieldset, which also expects an object. Also the targetElement object is set to $value. In both cases an object is expected, but because of recursive iteratorToArray call it will never be an object. The fix is to not do it recursively, this way it still gives a key => value array representation of the traversable, but still gives model objects that can be used by a hydrator or set as targetElement object. The above problem occurs when an extended Traversable that implements the toArray method is being used in the ArrayUtils::iteratorToArray method. Because it is recursive per default, it calls the toArray method on the traversable and in case this is implemented in a way that also calls toArray on all child elements, the whole traversable is converted to a scalar-only-array. So now that there are no object, the Zend\Form\Element\Collection::extract method can not use the hydrator extract method on an array. Also the targetElement hydrator can not do it. So the extract method fails even though there is probably an array containing a lot of nice values. The solution chosen by me is to not recursively transform. That works as shown in the two added testcases. Another fix would be to rewrite the way the extract method works. Or to better dictate how the traversable should be constrained to be transformed in a more controlled way.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Bug fix for Zend\Form\Element\Collection::extract() Conflicts: tests/ZendTest/Form/Element/CollectionTest.php
|
Thanks for merging into dev. I hope all is good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Traversable is encountered it is converted to an array.
By default this is done recursively, so that the Traversable becomes an array representation.
The result of that is saved in
$this->object.In the Collection::extract method when iterating over
$this->objectthere are two branches:$valueas an object.setObject($value)is called on a fieldset, which also expects an object. Also the targetElement object is set to$value.In both cases an object is expected, but because of recursive
iteratorToArraycall it will never be an object.The fix is to not do it recursively, this way it still gives a key => value array representation of the traversable,
but still gives model objects that can be used by a hydrator or set as targetElement object.