This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix Debug::getEscaper() never called at Debug::dump() when xdebug is loaded #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,7 +104,7 @@ public static function dump($var, $label = null, $echo = true) | |||
| . PHP_EOL . $output | |||
| . PHP_EOL; | |||
| } else { | |||
| if (!extension_loaded('xdebug')) { | |||
| if (!extension_loaded('xdebug') || null !== static::$escaper) { | |||
There was a problem hiding this comment.
This breaks the lazy load of getEscaper
|
@Maks3w done. please let me know if something I missed, thanks ;) |
because only called when we use setEscaper(new \Zend\Escaper\Escaper())
|
@Maks3w I have updated this PR |
| }, | ||
| "suggest": { | ||
| "ext/xdebug": "XDebug, for better backtrace output" | ||
| "ext/xdebug": "XDebug, for better backtrace output", |
There was a problem hiding this comment.
I'll change this to ext-xdebug on commit, as that's the proper format for extensions.
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
fix Debug::getEscaper() never called at Debug::dump() when xdebug is loaded
ghost
assigned
weierophinney
added a commit
to zendframework/zend-debug
that referenced
this pull request
May 15, 2015
…ix/escapercall fix Debug::getEscaper() never called at Debug::dump() when xdebug is loaded
weierophinney
added a commit
to zendframework/zend-debug
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-debug
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we set Debug::setEscaper(new \Zend\Escaper\Escaper) before Debug::dump() and we have xdebug, the getEscaper() never called. added condition so getEscaper() will be called.