-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
@ClemensSahs seems broken to me. What if a cookie contains |
any char in the value will be encode https://github.com/ZendFramework/zf2/blob/master/library/Zend/Http/Header/SetCookie.php#L209 |
Did you merge or just close? |
@basz |
Following the history of changes resume in #5118 (thank you to @kevinpapst) I suggest add an argument to |
@@ -208,7 +208,7 @@ public function getFieldValue() | |||
|
|||
$value = urlencode($this->getValue()); | |||
|
|||
$fieldValue = $this->getName() . '="' . $value . '"'; | |||
$fieldValue = $this->getName() . '=' . $value . ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess last quotes are unnecessary :)
@Maks3w Perhaps this is a possible Solutions for both cases? Some objections? If not I write tomorrow a test for that and push it in to this PR. |
@ClemensSahs add your solution and the feedback. |
I fine her if nobody have feedback we can merge this. |
+1 |
…hotfix/5118 Hotfix/5118
fix for #5118