This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix #5289 (abstract factories return type) #5293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the original check was for a boolean false, I think we should allow any value except a |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Fix #5289 (abstract factories return type) Conflicts: tests/ZendTest/ServiceManager/ServiceManagerTest.php
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Forward port #5293 Conflicts: library/Zend/ServiceManager/ServiceManager.php
ghost
assigned
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…si/hotfix/5289 Fix zendframework/zendframework#5289 (abstract factories return type) Conflicts: tests/ZendTest/ServiceManager/ServiceManagerTest.php
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
- do not call initializers if we have a null value
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Forward port zendframework/zendframework#5293 Conflicts: library/Zend/ServiceManager/ServiceManager.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5289
Just let me know if you consider allowing services to return
bool(false)as a BC break, because I'm not sure.In any case, imho it should be allowed.