This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[http] Adapt header field name validation to RFC definition #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,13 +69,17 @@ public function setFieldName($fieldName) | |||
| throw new Exception\InvalidArgumentException('Header name must be a string'); | |||
| } | |||
|
|
|||
| // Pre-filter to normalize valid characters, change underscore to dash | |||
| $fieldName = str_replace(' ', '-', ucwords(str_replace(array('_', '-'), ' ', $fieldName))); | |||
There was a problem hiding this comment.
@ralphschindler @weierophinney Why this was needed?
There was a problem hiding this comment.
Apache, basically. The PhpEnvironment-specfic request object may pull the headers from get_headers(), and those often substitute underscores for dashes.
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
[http] Adapt header field name validation to RFC definition
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
- s/_/-/ in header field names
|
Causes a BC break in code being used against OAuth2 spec servers. Should be a configurable option (default off). |
|
@fuashley Please open a new issue with your problem. This thread is closed |
ghost
mentioned this pull request
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…x/http-fieldname-check [http] Adapt header field name validation to RFC definition
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
- s/_/-/ in header field names
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.