This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add regression test for #5237 #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanotorresi too late for 2.2.5, as that was already tagged by the time this came in. |
|
@stefanotorresi Also, #5237 was against develop, and rightfully so as it had some internal changes in behavior. This will have to be for 2.3.0. |
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2013
Add regression test for #5237
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2013
ghost
assigned
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…si/test/abstract-factories Add regression test for zendframework/zendframework#5237
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for a bug in
ServiceManager::canCreateServiceWithName()that #4285 was supposed to fix but was actually fixed by #5237.@weierophinney
any chance to include both this and #5237 in 2.2.5? The bug is quite a nasty one.