This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix emails that contain lines that start with periods #5422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a unit test (which fails under the current master) and patch for the following problem:
When sending an email via SMTP that has a line in the message body that starts with a period character ("."), the message body gets chopped off at that line and the remote SMTP server closes the connection.
Although escaping code exists in Zend\Mail\Protocol\Smtp's data() method, it doesn't work since it splits the string on "\r\n" but the MimeMessage class uses "\n" for newlines.
Lines 285-291 of Mail/Protocol/Smtp.php:
}
https://github.com/zendframework/zf2/blob/master/library/Zend/Mail/Protocol/Smtp.php#L285-L290
Since $data is delimited on "\n" the period escaping never happens, so the message ends prematurely.