Paginator\Adapter\DbSelect custom query for count

[snapshotpl]

No description provided.

[ralphschindler]

Out of curiosity, what's the motivation to make it a constant?

[snapshotpl]

Column name from count query need to be always the same. It helps to use this name in own select.

[ralphschindler]

Oh, I see. So the expectation for providing your own select that will calculate a count is that the custom select would have to return a resultant with that particular column name. Is that right?

[snapshotpl]

Exactly! Additionally I can change this to first element of array.

[ralphschindler]

I like this addition. I'm still thinking about the cross-platform ramifications of not using a column name. What would the code look like? Perhaps:

$result = $statement->execute();
$row = $result->current();
return reset($row);

?

[snapshotpl]

Now this adapter building count select in the same way.

[ralphschindler]

Let me know when you want me to look at this PR. I think I have a couple of modifications to the API I might make. I wouldn't call the new method getSelectCount() because it will either be retrieving a previously set one, or it will always be returning a completely different object based off the original Select. I think I would either check if $this->customSelectCount is set, or call createSelectCount() which would do the making of a Select based of the provided Select.

With the addition of this solution, I think it provides an outlet for these kinds of problems that crop up in edge cases: #4673

Thoughts?

[ralphschindler]

ping.

[weierophinney]

Let's make this upper case; I know for DB2, lowercase will not work here.

[Ocramius]

@snapshotpl I manually merged the PR in 5fceff3

Please note that I removed the setter and converted it into an additional constructor argument.