This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Hotfix] Validator\File classes behaviour with empty value #5555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an empty
$_FILES
array would be passed to file validators under some circumstances, e.g. trying to upload a file that exceeds the php.iniupload_max_filesize
value.stream_resolve_include_path()
is used in place offile_exists()
across the wholeValidator\File
package and, while being faster, it actually returns the current working directory when called with an empty argument.this PR prevents the subsequent inconsistent behaviour of all the validators using
stream_resolve_include_path()
when trying to validate an empty value. (triggering errors/warnings, displaying wrong failed validation message, etc)Done/To-do