This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixes #4670 #5567
Merged
Fixes #4670 #5567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -649,7 +649,12 @@ public function removeMethod($methodName) | |||
| */ | |||
| public function hasMethod($methodName) | |||
| { | |||
| return isset($this->methods[$methodName]); | |||
There was a problem hiding this comment.
Instead normalize the array key at the moment of set the value.
There was a problem hiding this comment.
@Maks3w what you mean ?
There was a problem hiding this comment.
here write return isset($this->methods[strtolower($methodName)]);
and change line 603 adding a strtolower to the key var.
Replace 596 with a call to hasMethod
Refactor getMethod and removeMethod removing the loops
There was a problem hiding this comment.
As you see fixing the issue here only change the visible problem but don't fix the source of the problem.
|
@Maks3w done ;), please let me know if I missed something. thanks. |
|
What is the status of this? |
|
I'm waiting for merge or review again if any something missed... |
ghost
assigned
Maks3w
added a commit
that referenced
this pull request
Feb 15, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 15, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 15, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4670