This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter #5711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also applied php-cs-fixer
| @@ -108,16 +108,16 @@ public function writeAt($text, $x, $y, $color = null, $bgColor = null) | |||
| * If X or Y coordinate value is negative, it will be calculated as the distance from far right or bottom edge | |||
| * of the console (respectively). | |||
| * | |||
| * @param int $x1 Top-left corner X coordinate (column) | |||
There was a problem hiding this comment.
Please roll back every change not related with the fix
|
Stylistic changes reverted. |
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
- space after opening comment - removed a conditional by rephrasing and returning in the conditional body
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
…console Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
- space after opening comment - removed a conditional by rephrasing and returning in the conditional body
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
Zend\Console\Adapter\AbstractAdapter::writeTextBlock()method was not implemented, so I implemented it, added tests, and ranphp-cs-fixer.Also, in order to be able to verify how this method writes data, I added an array to the test asset class
ConsoleAdapter. Without this tracking array, the output buffering doesn't correctly show which data I expect since there isn't a way to track text in between calls toAbstractAdapter::setPos().