Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix for issue #5629 #5732

Closed
wants to merge 3 commits into from
Closed

Conversation

Martin-P
Copy link
Contributor

My first pull request, so I hope I did everything correctly 😃

@@ -5,6 +5,7 @@
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
* @package Zend_Http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need @Package here

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014

// Check header integrity
$this->assertEquals('timeout=15,max=100', $response->getHeaders()->get('keep-alive')->getFieldValue());
$this->assertEquals('text/html;charset=iso-8859-1', $response->getHeaders()->get('content-type')->getFieldValue());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I must have accidently removed that test.

weierophinney added a commit that referenced this pull request Mar 4, 2014
Fix for issue #5629

Conflicts:
	tests/ZendTest/Http/ResponseTest.php
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
Copy link
Member

Merged to develop for release with 2.3.0.

@Martin-P Martin-P deleted the issue-5629 branch August 13, 2014 14:00
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
…ue-5629

Fix for issue zendframework/zendframework#5629

Conflicts:
	tests/ZendTest/Http/ResponseTest.php
weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants