This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Make allowObjectBinding configurable for Fieldsets #5741
Merged
weierophinney
merged 14 commits into
zendframework:develop
from
veewee:fieldset-allowed-object-class
Mar 7, 2014
Merged
Make allowObjectBinding configurable for Fieldsets #5741
weierophinney
merged 14 commits into
zendframework:develop
from
veewee:fieldset-allowed-object-class
Mar 7, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allowed-object-class
…allowed-object-class
…allowed-object-class
…allowed-object-class
…allowed-object-class
…allowed-object-class
…allowed-object-class
bump: Any comments / progress? (Travis won't pass because of failed dependencies in composer. Tests should work fine!) |
@veewee I'm planning to merge this against develop for 2.3.0. However, it does not cleanly merge currently due to other pull requests I've merged in the last few days. It's possible one or more of these may solve the same problem; at the very least, changes conflict. Can you do the following please?
Thanks! |
ping @weierophinney |
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
Make allowObjectBinding configurable for Fieldsets
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a module with form annotations, I bumped into a problem:
This is because there is no object attached to the fieldset yet while binding a new object.
Therefor, it should be configurable which objects are allowed and which not.
This commit will make it possible to use
When an object is bound to the form, the getConnection() will return a Application\Entity\Connection instance. Therefore the custom hydrator will be used and the form will work as suspected.