This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Support PHPUnit 3.8+ compatibility #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 3.8+ adds a method to its PHPUnit_Framework_TestListener interface called addRiskyTest(). Need to stub it out to avoid "must implement this interface method" fatals when using 3.8+.
|
Please remove the trailing spaces |
|
I am sorry -- what trailing spaces? |
| @@ -107,7 +107,8 @@ public function addIncompleteTest(PHPUnit_Framework_Test $test, Exception $e, $t | |||
| public function addSkippedTest(PHPUnit_Framework_Test $test, Exception $e, $time) {} | |||
| public function startTestSuite(PHPUnit_Framework_TestSuite $suite) {} | |||
| public function endTestSuite(PHPUnit_Framework_TestSuite $suite) {} | |||
|
|
|||
| public function addRiskyTest(PHPUnit_Framework_Test $test, Exception $e, $time) {} // Support PHPUnit 3.8+ | |||
|
|
|||
There was a problem hiding this comment.
@JoelMarcey these trailing spaces (causes https://travis-ci.org/zendframework/zf2/jobs/18169328#L115 )
|
I believe I fixed this with c29404d |
|
friendly ping -- how often do pull requests get merged, out of curiosity? |
|
@JoelMarcey AFAIK, everyone conferencing right now. |
|
@Ocramius Ahh. Thanks. I am just looking forward to removing using my fork and using the official branch in our test runner :) |
ghost
assigned
Maks3w
added a commit
that referenced
this pull request
Feb 7, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 7, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 7, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 3.8+ adds a method to its PHPUnit_Framework_TestListener interface called addRiskyTest(). Need to stub it out to avoid "must implement this interface method" fatals when using 3.8+.