This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Removed Zend\Http\Client\Cookies #5840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ezimuel shouldn't you extend from the correct class and leave this one for BC compat? |
|
@Ocramius This class is not used in the framework, and makes no sense to use it. |
|
@ezimuel alright |
|
I think we need to declare it first as deprecated and then remove it in 2.3.0 and best if 2.4.0 |
I disagree. The reason @ezimuel created this PR is because of people indicating confusion over which one to use. Only one is correct in this particular case; the other, which is removed in this PR, cannot be used with the HTTP client in its current incarnation. |
weierophinney
added a commit
that referenced
this pull request
Feb 20, 2014
Removed Zend\Http\Client\Cookies Conflicts: library/Zend/Http/Client/Cookies.php
weierophinney
added a commit
that referenced
this pull request
Feb 20, 2014
weierophinney
added a commit
that referenced
this pull request
Feb 20, 2014
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…cookies Removed Zend\Http\Client\Cookies Conflicts: library/Zend/Http/Client/Cookies.php
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zend\Http\Client\Cookies is a misprint from ZF. The correct component is Zend\Http\Cookies. I removed it and fixed the unit test.