Multiple identifiers in In

[ojhaujjwal]

I have an SQL query like this:

SELECT * FROM data da INNER JOIN device_configuration d ON d.id = da.device_id WHERE (da.device_id, da.recorded_time) IN ( SELECT device_id, MAX(recorded_time) FROM data group BY device_id ) AND d.parent_id IS NULL;

Yes, you are right, it is not supported directly by Zend Framework 2.

With this PR, you can do something like:

$select->where->in(array('column1', 'column2'), $anotherSelect);

So, the above query can be written in Zend Framework 2 as:

$maxSelect->columns(array('device_id', new SqlExpression('MAX(recorded_time)')));
$maxSelect->group('device_id'); 
$select->where->in(array('device_id', 'recorded_time'), $maxSelect);
$select->join(
    'device_configuration',
    'device_configuration.id = data.device_id'
);
$select->where->isNull('parent_id');
$resultSet = $this->select($select); 

[Ocramius]

Alignment

[ojhaujjwal]

I have fixed this

[ojhaujjwal]

@Ocramius I have updated the code. I do not know why the build is failing?

[samsonasik]

see travis build here https://travis-ci.org/zendframework/zf2/jobs/19323397 , there is trailing_spaces need to be fixed. you can fix trailing space by php-cs-fixer and run :

php php-cs-fixer.phar fix /path/to/file.php --fixers=trailing_spaces

[ojhaujjwal]

@samsonasik I tried that. No luck!

[samsonasik]

you need to define what "No luck" is. what error you found ? have you follow the Readme ? https://github.com/fabpot/PHP-CS-Fixer/blob/master/README.rst#usage

[ojhaujjwal]

@samsonasik I did exactly the same command as you said. And, then I committed and it displayed that no change was detected. That is NO LUCK!

[ralphschindler]

This would need to change to null|string|array, and the later line needs to change to array|Select, i think

[ojhaujjwal]

@ralphschindler Thanks for pointing out that!

[ojhaujjwal]

@samsonasik It was my mistake. I only run cs-fixer in In.php and forgot to run in InTest.php
Now, I did and it worked!

[ralphschindler]

After looking at this, I think I'd like to find a way to accomplish this without a "dynamic" specification. Primarily, this usage pattern would break the NotIn predicate.

[ralphschindler]

Hey @ojhaujjwal, the solution you proposed looks to have a mutually exclusive condition where when the value is select, the identifier is processed as an array. I've made a different PR that will treat the identifier and values separately when processing them for the expression data, it is located here:

https://github.com/ralphschindler/zf2/tree/feature/5854-alternative

Can you tell me if this works for you?
This also takes into account the NotIn predicate as well.

[ralphschindler]

Merged to develop.