Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Post/Redirect/Get should keep query parameters #5861

Merged
merged 1 commit into from
Mar 4, 2014

Conversation

campersau
Copy link
Contributor

The Post Redirect Get Plugin should keep query parameters for redirects but I don't know if this is the right approach to do this.

@weierophinney
Copy link
Member

@campersau yes, looks good -- and your test proves it! :)

@weierophinney weierophinney added this to the 2.2.6 milestone Mar 3, 2014
@EvanDotPro
Copy link
Member

I'd have to agree, it probably should have done this from the beginning, however, I'm slightly concerned this could be a BC break, as this would change the default behavior of the plugin slightly.

I'm not saying they should, but if anyone who is using the prg plugin sets query parameters on their form action, but is, for any reason, relying on those parameters not being present after the redirect, this could possibly present an issue.

So we should either, A) acknowledge that this likely affects so few users (none?) that it's not worth worrying about, or B) perhaps add a third parameter to the __invoke() method to toggle this option, and default it to off so that behavior doesn't change.

@Ocramius
Copy link
Member

Ocramius commented Mar 4, 2014

@EvanDotPro a breakage here seems ok as long as it is documented. Manually redirecting is always possible anyway.

@EvanDotPro
Copy link
Member

@Ocramius fine by me. :)

@EvanDotPro
Copy link
Member

Corrected the title of this PR from Post/Request/Get to Post/Redirect/Get.

@EvanDotPro EvanDotPro self-assigned this Mar 4, 2014
@EvanDotPro EvanDotPro merged commit 502a522 into zendframework:master Mar 4, 2014
@campersau campersau deleted the prg_keep_query branch May 16, 2015 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants