This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
minor improvements to form labels #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2014 10:22
this should not be a BC break because the interface is not included in any release yet, change only affect develop branch
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| namespace Zend\Form; | |||
|
|
|||
| class LabelOptionsAwareTrait | |||
| class LabelAwareTrait | |||
There was a problem hiding this comment.
oops! typo :P
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
minor improvements to form labels
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
LabelOptionsAwareInterfacewas introduced in #4677 to preserve BC with 5.3.3, but since the whole functionality will make into 2.3 release and we're upping the minimum PHP version, some cleaning is due.also minor cleanup subsequent to #5533 and reinstated #5539 new feature
it is important to merge this along with #4677 (which hasn't made yet into any release) before 2.3, otherwise this would become a bc break for the very PR it's trying to clean up. ;)