This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/4785 csrf name conflicts #5918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 5, 2014 17:16
This reverts commit 3afc417. test was irrelevant and misleading
test was ignoring the actual validation method and doing the comparison by himself.
|
Yeah, not worried about the 5.3.3 test failures at all. Merging to develop for release with 2.3.0. |
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
…nflicts Hotfix/4785 csrf name conflicts
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…si/hotfix/4785-csrf-name-conflicts Hotfix/4785 csrf name conflicts
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should fix #4785
I'm not very sure about it, it is probably not very fancy, but I should have managed to fix the validator without adding any further state to it, actually even removing some, and maintain BC.
As far as I can tell, the only downside is that tokens are not statically cached any more and are regenerated each time a new validator instance is created (which may arguably be an improvement).
I had to edit
ZendTest\Form\FormElementManagerFactoryTestbecause it was a bit of a mess. I didn't delve too much into it, but further cleaning is possible. I honestly don't know how much of a test I can change for this purpose. Also, it is failing in php5.3.3only, no clue why. I suppose it's not a problem since this issue was tagged for milestone 2.3.0.