This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix console mixed case optional value params #5951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one slipped through.
When using optional value params in console routes, i.e.
Given the following script invocation:
We would receive the following route match:
Where it should be:
Notice that
withThisData
parameter became lowercasedwiththisdata
.@weierophinney - we need to include a note on that in release notes, in case someone just ignored the bug and consumed all-lowercased parameter names.