permissions : docBlock #5972
permissions : docBlock #5972
Conversation
| @@ -110,6 +110,7 @@ public function getRole($objectOrName) | |||
|
|
|||
| $it = new RecursiveIteratorIterator($this, RecursiveIteratorIterator::CHILD_FIRST); | |||
| foreach ($it as $leaf) { | |||
| /* @var RoleInterface $leaf */ | |||
There was a problem hiding this comment.
For IDE autocomplete
There was a problem hiding this comment.
I think that is suppose to be /** @var RoleInterface $leaf */
when used inline, at least that i how PHPStorm does it.
There was a problem hiding this comment.
I use PHPStorm and it actually use /**.
But it also understand /* and since Eclipse seems to prefer this last syntax, i thought it would be better.
There was a problem hiding this comment.
Really I prefer Docblock comment block syntax since @var is traditionally used in docblocks.
There was a problem hiding this comment.
Anyway this detail is not enough for do a change (even do a PR for this things)
| @@ -127,6 +128,7 @@ public function getRole($objectOrName) | |||
| * @param RoleInterface|string $role | |||
| * @param string $permission | |||
| * @param AssertionInterface|Callable|null $assert | |||
There was a problem hiding this comment.
You missed 1 more space to align with the @throws Exception\InvalidArgumentException as well :)
There was a problem hiding this comment.
👽 A little bit fussy on this one ! ^^
There was a problem hiding this comment.
Well, your PR aims to fix docblock 😄
There was a problem hiding this comment.
@danizord Alignment is not a valid reason for change a PR.
update docblock documentation