This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Form\Element\Select multiple is always required #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -270,4 +346,13 @@ protected function getOptionValue($key, $optionSpec) | |||
| { | |||
| return is_array($optionSpec) ? $optionSpec['value'] : $key; | |||
| } | |||
|
|
|||
| /** | |||
| * @return boolean | |||
There was a problem hiding this comment.
@return bool for consistency
| @@ -235,6 +292,24 @@ public function getInputSpecification() | |||
| 'required' => true, | |||
| ); | |||
|
|
|||
| if ($this->useHiddenElement() && $this->isMultiple()) { | |||
| $unselectedValue = $this->getUnselectedValue(); | |||
There was a problem hiding this comment.
What happens if $unselectedValue corresponds with a value in the dropdown?
There was a problem hiding this comment.
@Ocramius It would either be marked as selected, or that value would be considered a default value.
|
If nothing is selected, the hidden value returns a string. If at least one value is selected, the select element sends an array. There is no conflict, because the results are different types. I have added a testcase to the dataPovider for your example. |
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
Form\Element\Select multiple is always required
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
Close #6009 Fixes #4750 Fixes #5842 Fixes doctrine/DoctrineModule#215
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Select Element is always required. The Validation fails (required) if the multiple select is unselected. It is not possible to send an empty list.
I added the option for an hidden element. If nothing is selected the empty hidden field is send (required).
Select Element has the new Option 'use_hidden_element' and 'unselected_value'.
The FormSelect Helper generates an hidden element before the select element.
Reference to other Issues.
#4750, #5842, doctrine/DoctrineModule#215