Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Hotfix : Zend\Test trace error flag #6041

Closed
wants to merge 4 commits into from
Closed

Hotfix : Zend\Test trace error flag #6041

wants to merge 4 commits into from

Conversation

blanchonvincent
Copy link
Contributor

Current behavior is annoying because exception are automatically thrown ... currently, you can't assert application exception and debug your application

@@ -26,6 +26,8 @@ public function setUp()
include __DIR__ . '/../../_files/application.config.php'
);
parent::setUp();

$this->setTraceError(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest the opposite. This is an annoying breakage, and the feature should be opt-in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breakage? it's just a test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it will make any test based on (for example) testing unauthorized access break for consumer libraries. That's what I mean by "breakage"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius Ok I will change this, thank you Ocra

@Ocramius Ocramius added this to the 2.3.1 milestone Apr 2, 2014
@Ocramius Ocramius self-assigned this Apr 2, 2014
@Ocramius Ocramius closed this in 1158721 Apr 2, 2014
Ocramius added a commit that referenced this pull request Apr 2, 2014
gianarb pushed a commit to zendframework/zend-test that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-test that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants