This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix for issue 6076. avoid GlobIterator globbing to directories which it ... #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it will subsequently fail to unlink() by appending *.* instead of just * to path in clearByNamespace() and clearByPrefix(). *.* will glob to both .dat and .tag extensions
|
@brettmc can you provide a test for this one? |
|
See #6076 |
…or clearByPrefix shows that it's actually not an issue (due to the prefix itself differentiating a file from a dir), so revert my change to clearByPrefix
|
As noted in #6076 it should be done for |
…can try to remove a directory (eg if the prefix happens to collide with a partial md5 key), as pointed out by @marc-mabe in issue 6076
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
fix for issue 6076. avoid GlobIterator globbing to directories which it ... Conflicts: tests/ZendTest/Cache/Storage/Adapter/FilesystemTest.php
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
fix for issue 6076. avoid GlobIterator globbing to directories which it ... Conflicts: tests/ZendTest/Cache/Storage/Adapter/FilesystemTest.php
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...will subsequently fail to unlink() by appending . instead of just * to path in clearByNamespace() and clearByPrefix(). . will glob to both .dat and .tag extensions