This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Test Enable trace error by default #6108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discussed this before - this is a breakage. Marking for 2.4 |
|
Manually merged @32182a128396fa8553cc203beb990a2c091fd8c9 |
|
Hey The exception is raised and then handled by my (Zend) app during the dispatch event. The controller returns an HTTP 500 with a proper template (error/index). So When I try to handle this with a "$this->setExpectedException(...)", it does not work because no exception is raised in test, but the trace crashes my test. I don't want to set traceError to false everywhere, so what is the way to handle that ? Thxs |
gianarb
pushed a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
…e-error-display-enable' into develop Close zendframework/zendframework#6108
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to change this for a long time but I Had to wait for #6041, but now it's ok, we can enable trace error by default, it will be better for developer.
It's not a BC because if test is broken now, it's because the developer had an exception he didn't see, so it's better :)