This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow session garbage collection to use an index #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing arithmetic in the where clause prevents MySQL from using an index. The garbage collection becomes increasingly more expensive to run as traffic grows.
| @@ -164,10 +164,9 @@ public function destroy($id) | |||
| public function gc($maxlifetime) | |||
| { | |||
| $platform = $this->tableGateway->getAdapter()->getPlatform(); | |||
| return (bool) $this->tableGateway->delete(sprintf('%s + %s < %d', | |||
| return (bool) $this->tableGateway->delete(sprintf('%s < %d', | |||
There was a problem hiding this comment.
Does mysql really not optimize this?
There was a problem hiding this comment.
No, I can provide a sql fiddle to prove it.
There was a problem hiding this comment.
@hjr3 it's fine - I was really just wondering why MySQL always manages to disappoint me :D
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
Allow session garbage collection to use an index
weierophinney
added a commit
that referenced
this pull request
Apr 14, 2014
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Allow session garbage collection to use an index
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing arithmetic in the where clause prevents MySQL from using an index. The garbage collection becomes increasingly more expensive to run as traffic grows.