This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Session validation listeners may return null, erroneously causing validation to fail
#6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this may be a BC break |
Ocramius
added a commit
to zendframework/zend-developer-tools
that referenced
this pull request
Apr 16, 2014
|
Since the intended behavior would be to return false, this would not be a BC break. |
mwillbanks
pushed a commit
that referenced
this pull request
Apr 16, 2014
mwillbanks
pushed a commit
that referenced
this pull request
Apr 16, 2014
…n-values' into develop Forward port #6147
Ocramius
deleted the
hotfix/session-validation-listeners-null-return-values
branch
weierophinney
added a commit
to weierophinney/zend-developer-tools
that referenced
this pull request
Jul 11, 2014
- Per discussion with @Ocramius, a `null` value does not work currently until zendframework/zendframework#6147 is in a released version. That patch fixes a `!$value` call to more correctly be a `false === $value` call; until then, a truthy, but not boolean true, return value will also still work.
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…n-values' into develop Forward port zendframework/zendframework#6147
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @mwillbanks