Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix: Fix PHP-CS-Fixer to a working version #6180

Merged
merged 1 commit into from
Apr 23, 2014

Conversation

localheinz
Copy link
Member

Follows #6172 (comment).

Unfortunately a change I proposed in fabpot/php-cs-fixer results in failing builds on Travis.

See https://github.com/fabpot/PHP-CS-Fixer/pull/342.

@localheinz
Copy link
Member Author

@localheinz
Copy link
Member Author

As posted in #6172 (comment):

Another alternative would be to update .travis.yml:

script:
  - vendor/bin/php-cs-fixer fix --config-file=.php_cs -v --dry-run ./library

@localheinz
Copy link
Member Author

In my opinion, though, yet another alternative would be allow the path argument to be optional, since the paths are defined in the configuration in .php_cs anyway.

This would probably be the cleanest solution.

@samsonasik
Copy link
Contributor

@localheinz I applied your suggestion about updating .travis.yml on #6172 ...

@localheinz
Copy link
Member Author

@samsonasik

It's very likely that all of the PRs that have been building since fabpot/PHP-CS-Fixer@288b3ce will need to have this change as well.

@samsonasik
Copy link
Contributor

👍

Maks3w added a commit that referenced this pull request Apr 23, 2014
Maks3w added a commit that referenced this pull request Apr 23, 2014
@Maks3w Maks3w merged commit 87ff82d into zendframework:master Apr 23, 2014
Maks3w added a commit that referenced this pull request Apr 23, 2014
@localheinz localheinz deleted the bugfix/php-cs-fixer-bc branch April 23, 2014 19:18
@localheinz
Copy link
Member Author

@Maks3w

I'm working on making the path argument optional since

$ vendor/bin/php-cs-fixer fix --config-file=.php_cs -v --dry-run .

in combination with .php_cs (as it is) is only providing . as path argument because it's non-optional (I believe).

@Maks3w
Copy link
Member

Maks3w commented Apr 23, 2014

Thank you @localheinz

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants