This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix: Fix PHP-CS-Fixer to a working version #6180
Merged
Maks3w
merged 1 commit into
zendframework:master
from
localheinz:bugfix/php-cs-fixer-bc
Apr 23, 2014
Merged
Fix: Fix PHP-CS-Fixer to a working version #6180
Maks3w
merged 1 commit into
zendframework:master
from
localheinz:bugfix/php-cs-fixer-bc
Apr 23, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As posted in #6172 (comment): Another alternative would be to update
|
In my opinion, though, yet another alternative would be allow the This would probably be the cleanest solution. |
@localheinz I applied your suggestion about updating |
It's very likely that all of the PRs that have been building since fabpot/PHP-CS-Fixer@288b3ce will need to have this change as well. |
👍 |
Maks3w
added a commit
that referenced
this pull request
Apr 23, 2014
Maks3w
added a commit
that referenced
this pull request
Apr 23, 2014
Maks3w
added a commit
that referenced
this pull request
Apr 23, 2014
I'm working on making the
in combination with |
Thank you @localheinz |
This was referenced Apr 23, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #6172 (comment).
Unfortunately a change I proposed in
fabpot/php-cs-fixer
results in failing builds on Travis.See https://github.com/fabpot/PHP-CS-Fixer/pull/342.