-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
👍 |
WTF, php-cs-fixer again. |
This change fabpot/PHP-CS-Fixer@86a0f41 results in a failure when See https://github.com/fabpot/PHP-CS-Fixer/pull/349. |
I guess the regression mentioned above affects a bunch of PRs again? How about fixing the |
@Maks3w just a wild guess, but maybe the autoloader is only generated correctly with |
Any change in composer.json implies a composer update. |
As I said, the build needs to be restarted. |
@localheinz I restarted the build |
Manually rebased/merged |
This PR breaks PHPUnit testing on Windows machines.
When I place the original code back into <?php
/**
* Setup autoloading
*/
include_once __DIR__ . '/../vendor/autoload.php';
$loader = new Zend\Loader\StandardAutoloader(
array(
Zend\Loader\StandardAutoloader::LOAD_NS => array(
'ZendTest' => __DIR__ . '/ZendTest',
),
)
);
$loader->register(); |
@Martin-P is that a path mismatch? |
@Ocramius The path is not recognized anymore due to changing the autoloader. I opened issue #6737 for it and got a solution for this. I now need to execute an additional command to make the autoloader recognize the assets: It was not necessary before, so I did not know I needed to perform this extra step now to make it work. I guess this change only needs an update in the docs. |
I think we didn't use the global |
Only when installing ZF2 via composer, but when I fetch ZF2 directly from GitHub (as described in the README-GIT.md) there is no composer autoload involved. |
@Martin-P the first installation (even when testing) requires |
My comment went a bit early... I never needed |
Yeah, that was changed a lot of time ago: guess we missed updating the contributing notes :-\ |
Ah, okay, that explains my issue 😄 |
This feature exists since composer/composer#1344
This require update old composer installations