This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
#6218 - applying hotfix for iconv.internal_encoding deprecation
#6219
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precation See https://wiki.php.net/rfc/default_encoding > PHP 5.6 and master, introduce new php.ini setting. Old iconv.*/mbstring.* php.ini parameters will be removed for master PHP6. Use of iconv.*/mbstring.* php.ini parameters raise E_DEPRECATED for 5.6 and up.
|
This is not the good way. internal_encoding still having a special meaning on 5.6.
So set |
|
By the way. This is not a bug. (there is not nothing broken) |
|
@Maks3w the builds were throwing warnings without this |
|
And I'd also say that we should always keep our distance from deprecated features |
weierophinney
added a commit
that referenced
this pull request
May 7, 2014
…coding-deprecated-in-php-5.6 #6218 - applying hotfix for `iconv.internal_encoding` deprecation
weierophinney
added a commit
that referenced
this pull request
May 7, 2014
Ocramius
deleted the
hotfix/#6218-iconv-internal-encoding-deprecated-in-php-5.6
branch
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
…fix/zendframework/zendframework#6218-iconv-internal-encoding-deprecated-in-php-5.6 zendframework/zendframework#6218 - applying hotfix for `iconv.internal_encoding` deprecation
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…fix/zendframework/zendframework#6218-iconv-internal-encoding-deprecated-in-php-5.6 zendframework/zendframework#6218 - applying hotfix for `iconv.internal_encoding` deprecation
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6218
See https://wiki.php.net/rfc/default_encoding