This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix parameter format causing duplicate mails #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Trainmaster this needs a test case as well |
|
Updated SendmailTest.php. Is an extra test still neccessary? |
Recently I've experienced mails being duplicated and send to the sender when using the sendmail transport. After consulting my hosting company they told me there shouldn't been a space between "-f" and the envelope sender address. Removing the space character fixed the problem. No more duplicated mails being send to the sender. Furthermore I tested Swiftmailer and its sendmail transport layer. Absolutely no problems with it. Looking at the php docs there isn't a space character either, see http://www.php.net/manual/en/function.mail.php#example-3471. Furthermore I found http://stackoverflow.com/questions/4205228/basic-mail-function-php-additional-f-parameter-question and consulted the sendmail docs too: http://www.sendmail.org/~ca/email/man/sendmail.html. However, there are other examples around with a space character: http://stackoverflow.com/questions/179014/how-to-change-envelope-from-address-using-php-mail. Are they wrong? Since I'm not familiar with sendmail but actually trusting my hosting company I'm proposing to remove the space character.
|
Could need some insight from someone that understands mail protocols better than me. |
mwillbanks
added a commit
that referenced
this pull request
Aug 6, 2014
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
pushed a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I've experienced mails not only send to the recipient but also to the sender when using the sendmail transport. After consulting my hosting company they told me there shouldn't been a space between "-f" and the envelope sender address. Removing the space character fixed the problem. No more duplicated mails.
Furthermore I tested Swiftmailer and its sendmail transport layer. I had no problems with it.
Looking at the php docs there isn't a space character either, see http://www.php.net/manual/en/function.mail.php#example-3471. Furthermore I found http://stackoverflow.com/questions/4205228/basic-mail-function-php-additional-f-parameter-question and consulted the sendmail docs http://www.sendmail.org/~ca/email/man/sendmail.html.
However, there are other examples around with a space character: http://stackoverflow.com/questions/179014/how-to-change-envelope-from-address-using-php-mail. Are they wrong?
Since I'm not familiar with sendmail but actually trusting my hosting company I'm proposing to remove the space character.