This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fixing http query parameters #6231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zend\Stdlib\Parameters is not converted to PHP array in HHVM
|
@gmriggs can you write a test for this? |
|
Did a little digging... Here are some relevant issues / discussions: https://github.com/facebook/hhvm/blob/master/hphp/doc/inconsistencies#L90 It seems this is a known inconsistency. It's probably safest to just make the change in this PR, but we should look for other places we call PHP built-in functions that take arrays, and make sure we convert values to arrays prior to calling those functions. |
|
Confirmed, this is more of an HHVM issue |
|
@gmolson this is not going to be fixed in hhvm, so we can fix it on our side. In order to do that though, I need a failing test case... |
Ocramius
added a commit
that referenced
this pull request
Nov 14, 2014
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…parameters-to-array-cast-on-hhvm' Close zendframework/zendframework#6231
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…parameters-to-array-cast-on-hhvm' Close zendframework/zendframework#6231 Forward port zendframework/zendframework#6231
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…als with simpler ternaries where possible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend\Stdlib\Parameters is not converted to PHP array in HHVM