Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

add $label parameters to error, warn, info, log methods. issue #6370 #6374

Closed
wants to merge 4 commits into from
Closed

add $label parameters to error, warn, info, log methods. issue #6370 #6374

wants to merge 4 commits into from

Conversation

Redigast13
Copy link

See #6370

@Redigast13 Redigast13 mentioned this pull request Jun 14, 2014
Closed
@piteur
Copy link

piteur commented Jun 14, 2014

No default value ?
What about previous call to this methods ?

@ezimuel
Copy link
Contributor

ezimuel commented Aug 6, 2014

@Redigast13 this is a BC Break, you should provide a default value for $label, as suggested by @piteurPiriou. Can you provide also some unit test? Thanks.

@malukenho
Copy link
Member

@Redigast13 please rebase this PR!

@Ocramius Ocramius added this to the 2.4.0 milestone Nov 17, 2014
@Ocramius Ocramius self-assigned this Nov 17, 2014
Ocramius added a commit that referenced this pull request Nov 17, 2014
@Ocramius
#6374 #6370 - reverting BC break in interface signature, since PHP al…
8aa2ee9 
…lows additional optional parameters to be defined in implementing classes
Ocramius added a commit that referenced this pull request Nov 17, 2014
@Ocramius
#6374 #6370 - using nullable $label in the FirePhpBridge to avoid…
8da46a4 
… BC breaks
Ocramius added a commit that referenced this pull request Nov 17, 2014
@Ocramius
Merge branch 'feature/#6374-#6370-pass-label-to-firephp-bridge-log-wr…
5763d02 
…iter' into develop

Close #6374
Close #6370
@Ocramius
Copy link
Member

Merged into develop at 5763d02, thanks!

@Ocramius Ocramius closed this Nov 17, 2014
@Ocramius Ocramius mentioned this pull request Nov 22, 2014
Closed
gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6374 zendframework/zendframework#6370 - r…
ab9bac4 
…everting BC break in interface signature, since PHP allows additional optional parameters to be defined in implementing classes
gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Ocramius
zendframework/zendframework#6374 zendframework/zendframework#6370 - u…
066f92e 
…sing nullable `$label` in the `FirePhpBridge` to avoid BC breaks
gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'feature/zendframework/zendframework#6374-zendframework/…
11f8a84 
…zendframework#6370-pass-label-to-firephp-bridge-log-writer' into develop

Close zendframework/zendframework#6374
Close zendframework/zendframework#6370
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement Log
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Redigast13 @piteur @ezimuel @malukenho @Ocramius @weierophinney