This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Redis Server URI correct parsing #6495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including password support.
| @@ -216,6 +219,7 @@ protected function normalizeServer(&$server) | |||
| 'port' => $port, | |||
| 'timeout' => $timeout, | |||
| ); | |||
| return $password; | |||
There was a problem hiding this comment.
Why is the password being returned?
There was a problem hiding this comment.
It is returned because normalizeServer doesn't have access to the resource id / array to store the password. It is not an optimum solution but doing it a different way requires more code to be moved around as both the way the class manages the config internally and its methods don't take into account the fact the password could actually come from the URI of the server and not from a separate config entry.
There was a problem hiding this comment.
@franckstauffer I'm working on it right now. I'll see if I can move it somewhere else, as I don't like this return value.
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
…orage\Adapter\RedisResourceManager#setServer` and `#setResource`
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
…etServer` and `#setResource` implementation
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
|
@franckstauffer manually merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
… features of `Zend\Cache\Storage\Adapter\RedisResourceManager#setServer` and `#setResource`
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…pter\RedisResourceManager#setServer` and `#setResource` implementation
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…i-parsing' into develop Forward port zendframework/zendframework#6495
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including password support.
Some PaaS give you full-blown URIs to configure Redis (and other servers) - up until now the URIs were not parsed due to a bad condition in normalizeServer and there was no support for URIs containing a password anyway. This should fix both.